Partial fix #298623: export Symbol elements to MusicXML #8425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrio95
force-pushed
the
musicxml-export-symbol-elements
branch
from
cbf6320 to
42a6218
Compare
Exports Symbol elements to MusicXML as <other-direction> or <other-notation> tags, depending on a type of the symbol's parent element.
dmitrio95
force-pushed
the
musicxml-export-symbol-elements
branch
from
42a6218 to
70fafdd
Compare
vpereverzev
approved these changes
Jul 7, 2021
|
Just in case this ever gets backported to 3.x or 3.6.2_backend (@iveshenry18?): it needs #8273 getting backported first |
|
I'll keep it in mind! 3.6.2_backend is really prioritizing the importing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/298623 (partially)
Exports
Symbolelements to MusicXML as<other-direction>or<other-notation>tags, depending on a type of the symbol's parent element.
A test case can be added if MusicXML export tests get re-enabled, see my comment in #8273 (comment).