[MU3 Backend] ENG-52: Infer incorrectly exported fingerings #8298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

RomanPudashkin merged 2 commits into musescore:3.6.2_backend from iveshenry18:ENG-52-infer-fingerings

Jun 22, 2021

Contributor

iveshenry18 commented Jun 12, 2021

Resolves: ENG-52: Correct for incorrectly exported fingerings

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering class and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

iveshenry18 force-pushed the ENG-52-infer-fingerings branch from e36ca2e to 00c1237 Compare

June 14, 2021 18:25

its-not-nice approved these changes

View reviewed changes

vpereverzev approved these changes

View reviewed changes

Member

vpereverzev commented Jun 15, 2021

looking for rebase

iveshenry18 added 2 commits

June 15, 2021 11:34


          ENG-52: Infer incorrectly exported fingerings

cb47e8a

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.


          Add inferencing support for fingering changes

9bc651f

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

iveshenry18 force-pushed the ENG-52-infer-fingerings branch from 00c1237 to 9bc651f Compare

June 15, 2021 17:35

Contributor Author

iveshenry18 commented Jun 15, 2021

Rebased!

iveshenry18 mentioned this pull request

[MU3 Backend] ENG-25: Improve placement defaults #8325

Merged

8 tasks

RomanPudashkin merged commit cc08d34 into musescore:3.6.2_backend

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

94cbc4d

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

cf16f80

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

876f017

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

c8aea06

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

6060e36

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnigs

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

01dcec3

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz mentioned this pull request

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

Jojo-Schmitz reviewed

View reviewed changes

importexport/musicxml/importmxmlpass2.cpp

    
                                                                   QString placement,

                                                                   Measure* measure,

                                                                   Fraction tick)

                    : _totalY(totalY),  _text(text), _element(element), _track(track), _placement(placement), _measure(measure), _tick(tick)

Contributor

Jojo-Schmitz Jul 1, 2021 •

edited

Loading

Swapping _text(text) and _element(element) resolves a compiler warning (and gets them into the order of the argument list). Maybe another addition for #8481 .

Contributor Author

iveshenry18 Jul 1, 2021

Done!

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

5d61eea

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnigs

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

79ef923

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

iveshenry18 mentioned this pull request

[MU3 Backend] Fix more compiler warnings #8481

Merged

8 tasks

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

ed0d179

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8298

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

cfcf9bf

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

b872d21

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8298

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

206490f

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

9dca327

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8298

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

99aa718

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

1dc3a36

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8298

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

50f49ce

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

d4d535c

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8298

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

81ba6ed

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

a3ff5c6

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

d0755b6

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

8adbb85

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

c699fe2

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

fcff043

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

c28b28e

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz mentioned this pull request

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

357a540

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

a68df25

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate pf musescore#8298, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

652a45b

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

5d1756e

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

086eb6e

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate of musescore#8298, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

773bc0a

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

26a50e8

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate of musescore#8298, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

bc1229a

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

60388aa

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

9e577f6

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate of musescore#8298, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

e7e3b30

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

d48c754

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

d4321a6

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

09842f2

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

Jojo-Schmitz mentioned this pull request

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          ENG-52: Infer incorrectly exported fingerings

d822f43

A common error in exporters is misinterpreting fingerings as word-type
directions. This commit adds the MusicXMLInferredFingering and the
associated code necessary to detect these directions, find the correct
notes to add them to, then add them if such notes are found.

The current iteration is able to distribute the fingerings across voices
if necessary, as well as round the tick value of a direction to the
nearest greatest common denominator of the measure.

Duplicate of musescore#8298, part 1, plus 4 fixed compiler warnings, see musescore#8554

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Add inferencing support for fingering changes

ff29b7c

This simple addition to the isLikelyFingering() function adds
recognition of fingering changes of the form #-# or #–#. Also updates
corresponding tests.

Duplicate of musescore#8298, part 2

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          'Fix' mtest related to ENG-52

9b7b3ad

See musescore#8298, issue possibly caused by another commit though.
Here just disabling the test, as the output doesn't give any hints as to what the issue actually is.
```
62/62 Test #51: tst_mxml_io ......................***Failed   96.44 sec
   <diff -u /home/runner/work/MuseScore/MuseScore/mtest/musicxml/io/testInferredFingerings_ref.mscx testInferredFingerings.mscx failed

98% tests passed, 1 tests failed out of 62
```

miiizen mentioned this pull request

Port Infer XML fingering #22032

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet