[MU3] Fix #319242, fix #319020: Volta/Ottava/Pedal lines disappear when switching language #7804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tching language and while at it also remove a duplicate line and an unused variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and while at it also remove a duplicate line and an unused variable
Resolves: https://musescore.org/en/node/319242 and https://musescore.org/en/node/319020
Unfortunately I wasn't able to reproduce the issue in my local build, without this change (but was able to in 3.6.2), so I'm not 100% sure it fixes the issue. User feedback and testing with the GitHub artifact myself indicates that it does not fix the issue :-(
Also whether https://musescore.org/en/node/319020 really is the same issue is unclear.
To me the changes do make perfect sense though and are worth being done in any case, as the current code obviously is just wrong resp. superfluous.
This does not apply to master (which correctly starts with
idx = 0in both cases)