Skip to content

[MU3] "Add Frame Text" shortcut doesn't work #7622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2021
Merged

[MU3] "Add Frame Text" shortcut doesn't work #7622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions mscore/propertymenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,12 @@ void ScoreView::createElementPropertyMenu(Element* e, QMenu* popup)
popup->addAction(getAction("flip"));
else if (e->isHook())
popup->addAction(getAction("flip"));
else if (e->isTBox()) {
QMenu* textMenu = popup->addMenu(tr("Add"));
// borrow translation info from global actions
// but create new actions with local handler
textMenu->addAction(getAction("frame-text")->text())->setData("frame-text");
}
else if (e->isHBox()) {
QMenu* textMenu = popup->addMenu(tr("Add"));
// borrow translation info from global actions
Expand Down
4 changes: 4 additions & 0 deletions mscore/scoreview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2207,6 +2207,9 @@ void ScoreView::cmd(const char* s)
cv->changeState(ViewState::NORMAL);
cv->cmdAddChordName(HarmonyType::NASHVILLE);
}},
{{"frame-text"}, [](ScoreView* cv, const QByteArray&) {
cv->cmdAddText(Tid::FRAME);
}},
{{"title-text"}, [](ScoreView* cv, const QByteArray&) {
cv->cmdAddText(Tid::TITLE);
}},
Expand Down Expand Up @@ -4645,6 +4648,7 @@ void ScoreView::cmdAddText(Tid tid, Tid customTid, PropertyFlags pf, Placement p
if (tid == Tid::STAFF && customTid == Tid::EXPRESSION)
tid = customTid; // expression is not first class element, but treat as such
switch (tid) {
case Tid::FRAME:
case Tid::TITLE:
case Tid::SUBTITLE:
case Tid::COMPOSER:
Expand Down