Skip to content

Conversation

@dmitrio95
Copy link
Contributor

Resolves: https://musescore.org/en/node/314950

The following issues in the tracker are also probably describing the same issue:

The reason of those download issues is a 20 seconds download timeout introduced in #6546. For most applications within MuseScore it works fine but this timeout is too small for downloading extensions of tens of megabytes in size (which, of course, depends on the Internet connection speed). This pull requests increases the timeout up to 2 hours for downloading extensions, I am not sure though whether a timeout makes sense in this context.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 16, 2021

While 20 seconds surely is too short, 2 hours seems too long, maybe 10-20 minutes? These extensions are 82 MB resp. 22 MB in size

@dmitrio95 dmitrio95 force-pushed the extensions-download-timeout branch from 8adea7b to 5b605a3 Compare February 16, 2021 14:11
@dmitrio95
Copy link
Contributor Author

Actually I don't like a hard timeout here at all because it forces us to make assumptions on the Internet connection speed on the user's side. 20 minutes timeout would work only if download goes at a rate of at least approximately 70 KB/s — which is probably the case for most users but it is unclear why a download should fail if it goes somewhat slower. 2 hours don't make it much better anyway so I changed it to 20 minutes for now. But maybe a better solution would be to disable the timeout for extensions download and leave the timeout only for the other cases of using DownloadUtils.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Feb 16, 2021

If a download takes more than 2 hours, it is quite likely you don't want it to happen at all, I'd guess.
But timing out after 2 hours, and possibly 2 minutes before it might have finished would be quite annoying.

@dmitrio95
Copy link
Contributor Author

Yes, I agree that a 20 minutes timeout is probably better than 2 hours. The question is whether we want this timeout at all.

@vpereverzev vpereverzev merged commit 608827b into musescore:3.x Mar 4, 2021
@dmitrio95 dmitrio95 deleted the extensions-download-timeout branch March 4, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants