[MU3] Reimplement spacers in vertical staves adjustment to make sure all spacers are taken into account. #7529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njvdberg
added a commit
to njvdberg/MuseScore
that referenced
this pull request
Feb 19, 2021
Reimplement spacers in vertical staves adjustment to make sure all spacers are taken into account.
8 tasks
njvdberg
added a commit
to njvdberg/MuseScore
that referenced
this pull request
Feb 19, 2021
Reimplement spacers in vertical staves adjustment to make sure all spacers are taken into account.
njvdberg
added a commit
to njvdberg/MuseScore
that referenced
this pull request
Feb 19, 2021
Reimplement spacers in vertical staves adjustment to make sure all spacers are taken into account.
njvdberg
added a commit
to njvdberg/MuseScore
that referenced
this pull request
Feb 19, 2021
Reimplement spacers in vertical staves adjustment to make sure all spacers are taken into account.
njvdberg
added a commit
to njvdberg/MuseScore
that referenced
this pull request
Feb 23, 2021
Reimplement spacers in vertical staves adjustment to make sure all spacers are taken into account.
njvdberg
force-pushed
the
max-system-distance-3x
branch
from
d3981f6 to
5c9cd49
Compare
njvdberg
added a commit
to njvdberg/MuseScore
that referenced
this pull request
Feb 23, 2021
Reimplement spacers in vertical staves adjustment to make sure all spacers are taken into account.
igorkorsukov
pushed a commit
that referenced
this pull request
Feb 25, 2021
Reimplement spacers in vertical staves adjustment to make sure all spacers are taken into account.
|
Still needed for 3.x though |
vpereverzev
reviewed
Mar 9, 2021
njvdberg
force-pushed
the
max-system-distance-3x
branch
2 times, most recently
from
7f33d6b to
23508f2
Compare
…acers are taken into account.
njvdberg
force-pushed
the
max-system-distance-3x
branch
from
23508f2 to
ef5a6fe
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the ignored spacer between last staff and bottom of the page.
Also it was found some combination were not handled correctly. To solve this
distributeStaves()now implements it own code for finding the correctSpacerfor every spacing.A dedicated PR for
masterwill be created shortly.