fix #317272: page settings dialog shows wrong values in pre-3.6 parts

libmscore/score.cpp

@@ -358,6 +358,13 @@ Score* Score::clone()
       XmlWriter xml(this, &buffer);
       xml.header();
 
+      // TODO: this code to set MSC_VERSION explicitly causes the preview score in page settings dialog
+      // to always use current style defaults rather than those of the source score
+      // this clearly wrong for the page settings dialog and causes https://musescore.org/en/node/317272
+      // it's possible this code should be replaced by code that sets version based on the source score
+      // but it's also possible other code relies on the current behavior
+      // it's also possible MasterScore::clone() should contain the same change
+      // but for now, we are simply fixing up the style in PageSettings::setScore()
       xml.stag("museScore version=\"" MSC_VERSION "\"");
       write(xml, false);
       xml.etag();

mscore/pagesettings.cpp

@@ -104,6 +104,14 @@ void PageSettings::setScore(Score* s)
       cs = s;
       delete clonedScore;
       clonedScore = s->clone();
+      // HACK: clone doesn't actually copy style completely for older scores;
+      // instead it replaces any style settings that were at the older defaults with the current defaults
+      // this is not desired here, but might be in other places that Score::clone() is used
+      // so instead we simply re-copy the style here
+      int defaultsVersion = s->style().defaultStyleVersion();
+      clonedScore->style().setDefaultStyleVersion(defaultsVersion);
+      clonedScore->style() = s->style();
+
       clonedScore->setLayoutMode(LayoutMode::PAGE);
 
       clonedScore->doLayout();