Skip to content

Conversation

@worldwideweary
Copy link
Contributor

…an score selection during playback

Resolves: https://musescore.org/en/node/314060

Onscreen keyboard didn't update correctly with note events (like trills, tremolos between notes, mordents etc). This in my opinion could actually be considered a major bug rather than minor depending on the stress attached to the onscreen keyboard.

I don't know if the .COM side uses the same code for the production of its SEND-TO-YOUTUBE ability, but even there it also suffers from incorrect keyboard updating. It would be cool if this fixed the .COM side also, but that depends on whatever mechanisms are being utilized, and I don't have any information on that at the moment.

As an example, here is how it looks in 3.6.2 and below:
no-ornamentarticulation

And here is how it is with these changes
with-ornamentarticulation

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@igorkorsukov igorkorsukov changed the title Fix #314060: Onscreen Keyboard to show actual note events rather than only score selection during playback [MU3] Fix #314060: Onscreen Keyboard to show actual note events rather than only score selection during playback Feb 12, 2021
@vpereverzev vpereverzev merged commit ad17918 into musescore:3.x Mar 10, 2021
@Jojo-Schmitz
Copy link
Contributor

I wonder whether this would need to get ported to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants