-
Notifications
You must be signed in to change notification settings - Fork 3k
[MU3] Fix #317319: Remove unneeded skyline extension for time- and key signatures #7464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b190de to
28daf4c
Compare
28daf4c to
6de2b70
Compare
6de2b70 to
1c3ed63
Compare
|
Right, and as I observed on Telegram, the overlapping grace notes can happen even without this PR, if the grace note is a little higher above the staff. So I wouldn't worry about that with respect to this PR - to fix that there needs to be other changes to the spacing calculations. In the other cases here, right now there is clearly too much space, and this PR is a definitely improvement. Like, the first image above with the Ab and Abb, we're applying the "system header distance" to determine the distance to the first note, but inappropriately considering these fake extensions as something we need to clear, so we're measuring from there to the double flat on the higher note, rather than from the time signature itself to the lower note. This extra space was actually noted in a Facebook thread recently but I never got around to investigating. Anyhow, I approve these changes. |
…atures Backport of musescore#7498 resp. duplicate of musescore#7464
…atures Backport of musescore#7498 resp. duplicate of musescore#7464
…atures Backport of musescore#7498 resp. duplicate of musescore#7464
…atures Backport of musescore#7498 resp. duplicate of musescore#7464
…atures Backport of musescore#7498 resp. duplicate of musescore#7464
…atures Backport of musescore#7498 resp. duplicate of musescore#7464
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
|
See #9000 |
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
…atures Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.




Resolves: https://musescore.org/en/node/317319
Should go to master too, so see #7498 (merged there already)