Skip to content

Conversation

@Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Feb 10, 2021

Resolves: https://musescore.org/en/node/317319

Should go to master too, so see #7498 (merged there already)

@Jojo-Schmitz Jojo-Schmitz changed the title [MU3] Fix #317319: Remove unneeded skyline extensio for time- and key signatures [MU3] Fix #317319: Remove unneeded skyline extension for time- and key signatures Feb 10, 2021
@Jojo-Schmitz Jojo-Schmitz force-pushed the key-and-time-sig-skyline branch 2 times, most recently from 4b190de to 28daf4c Compare February 10, 2021 20:36
@Jojo-Schmitz Jojo-Schmitz force-pushed the key-and-time-sig-skyline branch from 28daf4c to 6de2b70 Compare February 10, 2021 20:52
@Jojo-Schmitz Jojo-Schmitz force-pushed the key-and-time-sig-skyline branch from 6de2b70 to 1c3ed63 Compare February 10, 2021 20:54
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Feb 11, 2021

The failed vtests are showing improvements, not failures actually. In general less space between time signature and 1st note (if there is no key signature) e.g. before:
accidental-23-ref
after
accidental-23-1
But also things like this, before:
slashed_grace-3-ref
after:
slashed_grace-3-1

@MarcSabatella
Copy link
Contributor

Right, and as I observed on Telegram, the overlapping grace notes can happen even without this PR, if the grace note is a little higher above the staff. So I wouldn't worry about that with respect to this PR - to fix that there needs to be other changes to the spacing calculations.

In the other cases here, right now there is clearly too much space, and this PR is a definitely improvement. Like, the first image above with the Ab and Abb, we're applying the "system header distance" to determine the distance to the first note, but inappropriately considering these fake extensions as something we need to clear, so we're measuring from there to the double flat on the higher note, rather than from the time signature itself to the lower note.

This extra space was actually noted in a Facebook thread recently but I never got around to investigating.

Anyhow, I approve these changes.

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 18, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 24, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 10, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Apr 26, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 11, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
@Jojo-Schmitz
Copy link
Contributor Author

See #9000

@Jojo-Schmitz Jojo-Schmitz deleted the key-and-time-sig-skyline branch September 2, 2021 10:29
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
…atures

Backport of musescore#7498 resp. duplicate of musescore#7464, Expected vtest failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants