fix #317163: properties lost on save/reload #7453
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/317163 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I foudn them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
MarcSabatella
force-pushed
the
317163-lost-properties
branch
from
40ee1b1 to
aace664
Compare
MarcSabatella
added a commit
to MarcSabatella/MuseScore
that referenced
this pull request
Feb 22, 2021
vpereverzev
pushed a commit
that referenced
this pull request
Feb 24, 2021
|
counterpart got merged to master |
|
Closed, since it's already in master |
|
Still needed in 3.x though |
|
Please reopen and merge into 3.x |
|
Several reports of this lately, FWIW. |
|
Please reopen and merge. |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 18, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 24, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 10, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Apr 26, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 11, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 28, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Resolves: https://musescore.org/en/node/317163 Backport of musescore#7597, resp. duplicated from musescore#7453 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number.
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Resolves: https://musescore.org/en/node/317163 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number. Backport of musescore#7597, resp. duplicated from musescore#7453
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Resolves: https://musescore.org/en/node/317163 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number. Backport of musescore#7597, resp. duplicated from musescore#7453
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Resolves: https://musescore.org/en/node/317163 The recent changes to style handling result in an extra styleChanged() call on load, which is not a problem in itself but exposes some existing problems in various read() functions. If styled properties were not marked as unstyled during the read, they get reset by this styleChanged() call, meaning any custom settings are lost on load. In fact, they would mostly have been lost after a *second* save/reload even in older versions, since the properties are not marked as unstyled and thus won't get written. But now they are lost immediately upon the first save/reload. The fix is to to be sure we mark the property unstyled on read, which basically means inserting calls to readStyledProperty() in the read() or readProperties() functions of various element types. This was originally reported for volta line style, and I quickly discovered it also appplies to line width, and to pedal line width. I then scanned the code looking for read() functions that did not handle styledProperties. I can't guarantee I found them all, but I did find the mmrest number offset and tuplet number text. The latter actually *seemed* to be handling the styled properties, but only for the tuplet itself, not the number. The font property flags needed to be copied to the number. Backport of musescore#7597, resp. duplicated from musescore#7453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/317163
The recent changes to style handling
result in an extra styleChanged() call on load,
which is not a problem in itself
but exposes some existing problems in various read() functions.
If styled properties were not marked as unstyled during the read,
they get reset by this styleChanged() call,
meaning any custom settings are lost on load.
In fact, they would mostly have been lost after a second save/reload
even in older versions, since the properties are not marked as unstyled
and thus won't get written.
But now they are lost immediately upon the first save/reload.
The fix is to to be sure we mark the property unstyled on read,
which basically means inserting calls to readStyledProperty()
in the read() or readProperties() functions of various element types.
This was originally reported for volta line style,
and I quickly discovered it also appplies to line width,
and to pedal line width.
I then scanned the code looking for read() functions
that did not handle styledProperties.
I can't guarantee I foudn them all,
but I did find the mmrest number offset and tuplet number text.
The latter actually seemed to be handling the styled properties,
but only for the tuplet itself, not the number.
The font property flags needed to be copied to the number.