[MU3] Fix #312254: Add alternative choice of “To Coda” #6847
Conversation
Jojo-Schmitz
force-pushed
the
to-coda-sym
branch
from
e012929 to
123b76d
Compare
|
mtest fails in tst_palette, but without any decent error message, leaving us a bit in the dark here. Probably due to using the identical tooltip "To Coda". So either that needs to get changed, or declared as an exception. let's go for the former and make it "To Coda (Symbol)" (put prepare the mtest for the latter). 3rd alternative would be to add this to the master palette only. 4th alternative would be to use therCoda symbols in the tooltip, "To 𝄌" (workspace) resp. "To \U0001D10C" (master palette), not sure that what screen readers make out of that? I finally went for a combination of 2nd and 3rd, i.e. "To Coda (Symbol)" but only in the master palette. |
Jojo-Schmitz
force-pushed
the
to-coda-sym
branch
from
6979c5c to
e540046
Compare
| break; | ||
|
|
||
| case Type::TOCODASYM: | ||
| txt = "To <font size=\"20\"/><sym>coda</sym>"; |
There was a problem hiding this comment.
Unfortunately we have to hard code the size of that symbol (here to the default size of the 'plain' Coda, 20 pt), it'd be way too small otherwise (12 pt per default).
share/workspaces/Advanced.xml
Outdated
| <Cell name="To Coda"> | ||
| <Marker> | ||
| <style>Repeat Text Left</style> | ||
| <text>To <font size="20"/><sym>coda</sym></text> |
There was a problem hiding this comment.
Unfortunately we have to hard code the size of that symbol (here to the default size of the 'plain' Coda, 20 pt), it'd be way too small otherwise (12 pt per default).
| { Marker::Type::CODETTA , QT_TRANSLATE_NOOP("markerType", "Codetta") }, | ||
| { Marker::Type::FINE , QT_TRANSLATE_NOOP("markerType", "Fine") }, | ||
| { Marker::Type::TOCODA , QT_TRANSLATE_NOOP("markerType", "To Coda") }, | ||
| { Marker::Type::TOCODASYM, QT_TRANSLATE_NOOP("markerType", "To Coda (Symbol)")}, |
There was a problem hiding this comment.
To be able to distinguish the 2 Codas, esp. for visually impaired users (and to appease the tst_palette mtest)
Jojo-Schmitz
changed the title
Jojo-Schmitz
changed the title
Add a "To<sym>coda</</sym>" to master "Repeats and Jumps" palette. The "To " part of it is sort of needed to tell it from the plain Coda in the palettes (so to not have to rely on the tool tip only), but is likely to not be wanted in score, so needs to get deleted there manually. Removing some rather rare symbols from the Basis workspace's "Repeats and Jumps" palette, namely "Segno variation" and "Varied coda".
Jojo-Schmitz
force-pushed
the
to-coda-sym
branch
from
e540046 to
148e8e2
Compare
2 participants
Add a "To
<sym>coda</sym>" to master "Repeats and Jumps" palette .The "To " part of it is sort of needed to tell it from the plain Coda in the palettes (so to not have to rely on the tool tip only), but is likely to not be wanted in score, so needs to get deleted there manually.
Seems we need to hardcode the size of the Coda symbol.
Removing some rather rare symbols from the Basis workspace's "Repeats
and Jumps" palette, namely "Segno variation" and "Varied coda".
Resolves https://musescore.org/en/node/312254
Port to MuseScore 4 needed too I guess, I'll take care of it once this PR passed muster ;-)