fix #312083: tempofield in new score wizard not accessible #6789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/312083 A quirk in Qt prevents screen readers from recognizing UI elements that are part of groups that were disabled in the UI file. Fix is to enable the group in the UI file but then disable it in the code.
74 tasks
| connect(tsCutTime, SIGNAL(toggled(bool)), SLOT(cutTimeToggled(bool))); | ||
| connect(tsFraction, SIGNAL(toggled(bool)), SLOT(fractionToggled(bool))); | ||
| pickupMeasure->setChecked(false); // checked in the UI file to enable screen reader on pickup duration controls | ||
| tempoGroup->setChecked(false); |
There was a problem hiding this comment.
Might be worth a comment in the code?
There was a problem hiding this comment.
Even though it’s the same comment as the line above? I actually copied the line but deleted the comment on purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/312083
A quirk in Qt prevents screen readers from recognizing UI elements
that are part of groups that were disabled in the UI file.
Fix is to enable the group in the UI file
but then disable it in the code.