[MU3] fix #311621: fixed export audio on Windows #6665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscore/exportaudio.cpp
Outdated
| sf = sf_open_fd(file.handle(), SFM_WRITE, &info, false); | ||
| sf = sf_wchar_open(wpath, SFM_WRITE, &info); | ||
| #else // Q_OS_WIN | ||
| sf = sf_open(qPrintable(filename); |
There was a problem hiding this comment.
closing paren missing!
There was a problem hiding this comment.
closing paren missing!
fixed
igorkorsukov
force-pushed
the
mu3/ci/winoggflac
branch
2 times, most recently
from
a1029b2 to
363c3cb
Compare
igorkorsukov
changed the title
Thanks, added |
igorkorsukov
force-pushed
the
mu3/ci/winoggflac
branch
from
363c3cb to
047a939
Compare
|
I've tried out the (Windows 64bit, the 32bit one seems pretty empty) artifact and it does solve the issue, it doeseacport to .flac, .ogg and .wav |
Greate! Thank you! |
21 tasks
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed this issue by another method #6531
But not working with MSVC build.
Possible, need use _get_osfhandle (https://stackoverflow.com/questions/50191480/how-to-get-a-windows-handle-from-a-qfile-or-qsavefile-for-reopenfile)
But I had the app crash.
So, now I implemented this solution - working (tested on MSVC build)