Skip to content

Conversation

@Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Sep 3, 2020

See https://musescore.org/en/node/309973

2 of those are in use by (and via) the German translation since long.

As it changes translatable strings, this PR is not for 3.5.1, but might be for 3.6.

Question is whether more of those are wanted?

@MarcSabatella
Copy link
Contributor

Yes, I would love mnemonics for Parts and Export!

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Sep 3, 2020

I'd think "Print…" should take precedence though (for the P), as that is largely a standard one? What character then to take for "Parts…"? The a?
"Export…" should be easy (the E). Hmm, maybe not, the x is also a good candidate.

One other thing to keep in mind: those mnemonics are quite a pain for translators

Adding mnemonics for Save, Save As… and Resource Manager…, Print…,
Parts… and Export…

See https://musescore.org/en/node/309973
@ecstrema
Copy link
Contributor

ecstrema commented Sep 3, 2020

Automatic mnemonics would be great for menus, though.

@Jojo-Schmitz
Copy link
Contributor Author

Not sure this is possible

@njvdberg
Copy link
Contributor

njvdberg commented Sep 4, 2020

Useful extension, I wasn't aware MuseScore didn't support this already 😉
But looking closely, I see all item in the main menu has this & but within the menu the usage of & is not very consistent. Is it an idea to include the & in all menu items?

@Jojo-Schmitz
Copy link
Contributor Author

It might. Maybe not for all, but for some, more than currently. Still the issue with being a pain for the translators, which for a different word need to find a different non-colliding mnemonic

@ecstrema
Copy link
Contributor

ecstrema commented Sep 4, 2020

Not sure this is possible

Why, not? It seems pretty straight forward to me: loop through the menu items and use first letter available.
Plus, it would prevent exactly the problem that you described above: mnemonics would never be shown in translatable strings, since they would get added later.

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Sep 4, 2020

Because it isn't straight forward at all. More often than not the 1st letter is used multiple times, e.g: Save, Save As, Save Online, Save a Copy, Save Selection, Score Properties, and also Parts vs Print, and Open vs Open Recent, and Export vs Export Parts, all these only in the File menu.

Then Print should get the P, as that is what others do, not Parts, and R for Open Recent makes much more sense than p.

Those mnemonics need to get carefully chosen and for every language, an automatism is doomed to fail or produce bad results.

@ecstrema
Copy link
Contributor

ecstrema commented Sep 4, 2020

Let's just say it's impossible then.

@njvdberg
Copy link
Contributor

njvdberg commented Sep 5, 2020

Impossible is too strong worded :-) but I see the point @Jojo-Schmitz made. It is not an issue for programmers but for the translators and to get it working over all menu items, a coordinated effort of the translators is required.

@Jojo-Schmitz
Copy link
Contributor Author

Well, next to impossible to do this in an automatic and sensible way, and across all languages, pretty easy to do it just for English by hand-coding those & (see this PR), but then painful for translators, hence better done only for the most common menus.

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 29, 2020
30 tasks
@Jojo-Schmitz
Copy link
Contributor Author

It is in master now, waiting for it to get merged into 3.x for 3.6

@Jojo-Schmitz Jojo-Schmitz changed the title Add mnemonics for Save, Save As… and Resource Manager… [MU3] Add mnemonics for Save, Save As… and Resource Manager… Oct 20, 2020
@vpereverzev vpereverzev merged commit fcb6748 into musescore:3.x Oct 21, 2020
@Jojo-Schmitz Jojo-Schmitz deleted the mnemonics branch October 21, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants