Skip to content

Conversation

@rpatters1
Copy link
Contributor

Resolves: #30919

The data members of StyleDef appear to have been inadvertently made public. This PR corrects that.

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@rpatters1 rpatters1 force-pushed the private-styledef-properties branch from a5b6f2c to fc86fe8 Compare November 11, 2025 15:41
cbjeukendrup added a commit to cbjeukendrup/MuseScore that referenced this pull request Nov 12, 2025
@cbjeukendrup
Copy link
Member

cbjeukendrup commented Nov 13, 2025

The plan was to merge this via #31006, but I hadn't noticed that you had rebased this two days ago, so my merge commit only included an old version of this PR so the trick didn't work. So I'll have to close this as "kind of manually merged".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current definition of StyleDef exposes supposedly private members.

2 participants