Skip to content

Conversation

@juli27
Copy link
Contributor

@juli27 juli27 commented Nov 5, 2025

Resolves: #30878

This causes the modern print dialog to be used again with Windows 11. See commit for details.
The second commit sets the min and max pages to the print dialog to allow the print dialog to validate user input (doesn't work with the modern print dialog in Windows 11..., but works with the legacy dialog in Windows 10 and maybe other platforms too)

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

Resolves: musescore#30878

When the print dialog doesn't have a owning window, the desktop window is
used on Windows. This causes the print dialog to be free-floating and
the legacy print dialog to be shown with Windows 11.
@cbjeukendrup
Copy link
Member

@DmitryArefiev For this PR, please check the functionality of the print dialog:

  • correct kind of dialog should appear on each OS
  • dialog is positioned okay, interaction works
  • on OSs that support it (i.e. apparently not Windows 11), the dialog should disallow entering a page number that's bigger than the number of pages in the score

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4.6.2 Build is Using Windows XP era Print Dialog

3 participants