Improve behaviour when dragging elements between systems #27480
Conversation
Probably wouldn't ever cause problems in practice, but still...
Otherwise, when dragging between systems, the element jumps around vertically.
Probably wouldn't ever cause problems in practice, but still... Backport of musescore#27480, commit 1
Probably wouldn't ever cause problems in practice, but still... Backport of musescore#27480, commit 1
Probably wouldn't ever cause problems in practice, but still... Backport of musescore#27480, commit 1
|
Wouldn't this have needed testing before merging? |
| if (y < y2) { | ||
| systems.push_back(s); | ||
| for (size_t iii = i + 1; ii < n; ++iii) { | ||
| for (size_t iii = i + 1; iii < n; ++iii) { |
There was a problem hiding this comment.
Even without thinking through the code, this much seems like a straight up bug fix, right?
There was a problem hiding this comment.
Yes, but I don't think it has any effect because the break below would be hit.
|
This does fix the random-seeming behavior when dragging more than a small amount, where the text would suddenly attach to the top of the page or somewhere else. So now it appears to work as designed. I would still prefer we simply disable the reanchoring across systems, as it's rarely what someone is trying to do in dragging text. In crowded lead sheets or instrument parts, we're still likely to see complaints, as it is not at all uncommon that someone might be trying to place a rehearsal mark above one staff and have it be physically closer to the staff above. That should be possible without needing to know about Alt+drag (or using keyboard adjustments). But if disabling the reanchor across systems not a viable option, then this is definitely a huge improvement, so thanks! |
…systems_goes_wild Improve behaviour when dragging elements between systems
3 participants
Resolves: #27101
It improves the situation, but it won't be perfect yet, and I suspect that's because of the
ldata->moveYinAutoplace::rebaseOffset, because we're unable to adjust theinitOffsetaccordingly.