Skip to content

Conversation

@Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Apr 21, 2022

The version of IntervalTree we are using has received many upstream updates, however these have not been merged into here since 2013.

Shamelessly stolen from #8808, to have it rebased and be able to check the utests.

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Apr 21, 2022
8 tasks
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Apr 21, 2022

vtests differ in 2 cases, before:
line-2-1 ref
and
line-3-1 ref
After:
line-2-1
and
line-3-1
I don't think those differences are acceptable, loosing quite a bunch of lines, but don't know how this PR might have caused them? Apparently the lines crossing a system break are getting lost.
My guess is that back when PR #8808 had last been touch the vtests were not functional at all, so didn't fail for just that reason.

The utests too seem to fail due to missing lines (slurs, hairpins, etc.).

My backport to 3.x though didn't have those issues as far as I can tell, see 8ef1c5c

@Jojo-Schmitz Jojo-Schmitz marked this pull request as draft May 10, 2022 07:58
@Jojo-Schmitz Jojo-Schmitz force-pushed the interval-tree branch 2 times, most recently from 3ab2130 to 254b0fe Compare November 20, 2022 14:33
@Jojo-Schmitz Jojo-Schmitz marked this pull request as ready for review November 20, 2022 15:00
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Nov 20, 2022

Another rebase, to resolve merge conflicts, no vtest differences anymore (so these weren't the fault of this PR, as suspected).
No unit test failures any more either, so ready for review!

@vpereverzev: mind to review? As you wanted it rebased back in April: #8808 (comment)

@Jojo-Schmitz
Copy link
Contributor Author

Once again a request to have this reviewed and merged.

@RomanPudashkin RomanPudashkin requested review from igorkorsukov and removed request for RomanPudashkin May 10, 2023 12:14
@igorkorsukov igorkorsukov merged commit 83fa707 into musescore:master May 10, 2023
@Jojo-Schmitz Jojo-Schmitz deleted the interval-tree branch May 10, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants