Skip to content

Extend features flags config values #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: development
Choose a base branch
from
Draft

Extend features flags config values #1492

wants to merge 5 commits into from

Conversation

bogdan-rosianu
Copy link
Contributor

Reasoning

  • not all the features activation flags were exposed via Rest API

Proposed Changes

  • add missing flags

How to test

  • check localhost:3001/about endpoint

@bogdan-rosianu bogdan-rosianu self-assigned this May 6, 2025
dragos-rebegea
dragos-rebegea reviewed May 6, 2025
View reviewed changes
src/common/api-config/api.config.service.ts Outdated
@@ -893,7 +893,9 @@ export class ApiConfigService {
}

getAssetsCdnUrl(): string {
return this.configService.get<string>('features.assetsFetch.assetesUrl') ?? 'https://tools.multiversx.com/assets-cdn';
return this.configService.get<string>('features.assetsFetch.assetsUrl')
?? this.configService.get<string>('features.assetsFetch.assetesUrl')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a todo to remove this in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025 •
edited
Loading

k6 load testing comparison.
Base Commit Hash: 918e8de
Target Commit Hash: a89359d

Metric Base Target Diff
AvgMax9095AvgMax9095AvgMax9095
Blocks67.251559.5262.1768.3484.21877.86120.19129.92+25.21% 🔴-43.71% ✅+93.32% 🔴+90.10% 🔴
Tokens57.42555.8761.3764.08157.694549.07169.41181.18+174.61% 🔴+718.37% 🔴+176.06% 🔴+182.76% 🔴
Mex57.49644.7061.3863.8265.032111.1484.0587.71+13.11% 🔴+227.46% 🔴+36.92% 🔴+37.44% 🔴
Pool57.14339.7461.4164.0664.811637.8683.9087.78+13.42% 🔴+382.09% 🔴+36.63% 🔴+37.04% 🔴
Transactions76.461558.3462.5570.40191.2821799.93124.52129.06+150.18% 🔴+1298.92% 🔴+99.09% 🔴+83.32% 🔴
Accounts58.751496.7961.4064.3265.61563.8185.1192.71+11.67% 🔴-62.33% ✅+38.61% 🔴+44.15% 🔴
Nodes56.68155.2161.3363.41132.6124560.5586.7190.47+133.97% 🔴+15724.13% 🔴+41.37% 🔴+42.68% 🔴
Test Run Duration60002.4960001.95

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

cfaur09
cfaur09 previously approved these changes May 6, 2025
View reviewed changes
@dragos-rebegea dragos-rebegea marked this pull request as draft June 3, 2025 14:30
@bogdan-rosianu
Merge branch 'development' into extend-about-features-configs
9c92d90 
# Conflicts:
#	config/config.devnet.yaml
#	config/config.mainnet.yaml
#	config/config.testnet.yaml
@bogdan-rosianu
fixes after merge
a89359d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragos-rebegea dragos-rebegea dragos-rebegea left review comments

@cfaur09 cfaur09 cfaur09 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@bogdan-rosianu bogdan-rosianu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdan-rosianu @dragos-rebegea @cfaur09