setup.py: cosmetic fixes #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Do you mind rebasing on the main branch (or merging from main)? I merged #154 and it now conflicts. |
Detected by pyflakes3. Signed-off-by: Simon McVittie <[email protected]>
Detected by pycodestyle. Signed-off-by: Simon McVittie <[email protected]>
smcv
force-pushed
the
setup-py-cosmetic
branch
from
da1064c to
984849b
Compare
Contributor
Author
Sure, done. |
multani
approved these changes
Nov 11, 2024
Owner
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #154 to avoid merge conflicts, please review/merge that first.
I ran some QA tools against setup.py to check that I hadn't done anything obviously wrong in #154, and they produced some unrelated warnings, most of which are fixed here.
setup.py: Remove unused imports
Detected by pyflakes3.
setup.py: Use PEP8 whitespace
Detected by pycodestyle.