[fix] detect multiple versions of nject and fail #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
nject.go:147
- Returning a provider instance with a fatal error instead of panicking changes the failure handling behavior. Please ensure that the rest of the code properly checks and handles the fatal error field to avoid silent failures.
return &provider{ ... fatal: fmt.Errorf("cannot turn Collection into a function"), ... }
Comment on lines
+310
to
+311
| switch fmt.Sprintf("%T", fn) { | ||
| case "nject.Collection", "*nject.Collection", "nject.provider", "*nject.provider": |
There was a problem hiding this comment.
Consider using a type assertion or a type switch directly on fn instead of comparing its type as a formatted string. This would be a more robust and type-safe approach to detect multiple versions of nject.
Suggested change
| switch fmt.Sprintf("%T", fn) { | |
| case "nject.Collection", "*nject.Collection", "nject.provider", "*nject.provider": | |
| switch fn.(type) { | |
| case *Collection, Collection, *provider, provider: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that there is a v2, there is a problem with combining with v1.
Fail when there is a mismatch of versions.