[DataGrid] Add touch support on column resize #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtassone
reviewed
Nov 4, 2020
packages/grid/_modules_/grid/hooks/features/useColumnResize.tsx
Outdated
Show resolved
Hide resolved
dtassone
reviewed
Nov 4, 2020
packages/grid/_modules_/grid/hooks/features/useColumnResize.tsx
Outdated
Show resolved
Hide resolved
oliviertassinari
requested changes
Nov 4, 2020
packages/grid/_modules_/grid/hooks/features/useColumnResize.tsx
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/hooks/features/useColumnResize.tsx
Outdated
Show resolved
Hide resolved
oliviertassinari
changed the title
oliviertassinari
added
scope: data grid
oliviertassinari
requested changes
Nov 6, 2020
Member
oliviertassinari
left a comment
oliviertassinari
left a comment
There was a problem hiding this comment.
- On Android, I can no longer sort
- On iOS it sorts when I resize
packages/grid/_modules_/grid/hooks/features/useColumnResize.tsx
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/components/styled-wrappers/GridRootStyles.ts
Outdated
Show resolved
Hide resolved
packages/grid/_modules_/grid/hooks/features/useColumnResize.tsx
Outdated
Show resolved
Hide resolved
Member
|
The hover style gets persisted on mobile, fixed in d8df748.
|
Member
|
The following error is thrown when using the resize (dev & prod)
That was because the |
…e/DataGrid-416-column-resize-mobile-support
…ithub.com:DanailH/material-ui-x into feature/DataGrid-416-column-resize-mobile-support
oliviertassinari
approved these changes
Nov 6, 2020
Member
|
@DanailH Well done :). We don't have any resizing tests for the mouse part of the logic. I think that we could consider adding some, but I think that it can be merged without. We could wait to solve a regression to add them. |
oliviertassinari
force-pushed
the
feature/DataGrid-416-column-resize-mobile-support
branch
from
c4f72cd to
1551072
Compare
…ithub.com:DanailH/material-ui-x into feature/DataGrid-416-column-resize-mobile-support
dtassone
reviewed
Nov 9, 2020
packages/grid/_modules_/grid/hooks/features/useColumnResize.tsx
Outdated
Show resolved
Hide resolved
dtassone
reviewed
Nov 9, 2020
packages/grid/_modules_/grid/hooks/features/useColumnResize.tsx
Outdated
Show resolved
Hide resolved
dtassone
approved these changes
Nov 9, 2020
dtassone
pushed a commit
to dtassone/material-ui-x
that referenced
this pull request
Nov 9, 2020
* Add support for touch column resize * Change the touch start event listner from the separator to the document * Allow resizing on mobile only when column separator is touched * fix hover * Attach touchStart event to the columns header element, not the document * Add support for touch column resize * Change the touch start event listner from the separator to the document * Allow resizing on mobile only when column separator is touched * Attach touchStart event to the columns header element, not the document * fix hover * minimize git diff * Use findParentElementFromClassName dom util * Add new findHeaderElementFromField dom util Co-authored-by: Olivier Tassinari <[email protected]>
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416
This PR adds the ability to resize columns on touch devices. The solution was taken from the
Slidercomponent that is part of the core repo -> https://github.com/mui-org/material-ui/blob/0d0e370c6e783f967fbd922ac925f576bee2b9ae/packages/material-ui/src/Slider/Slider.js#L675Preview: https://deploy-preview-537--material-ui-x.netlify.app/components/data-grid/#commercial-version