[core] Drop _modules_ folder
#3953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… GridApi and GridApiRef
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
6 tasks
flaviendelangle
requested review from
alexfauquette,
cherniavskii and
m4theushw
m4theushw
reviewed
Feb 17, 2022
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
alexfauquette
approved these changes
Feb 17, 2022
|
Are the conflicts easy to solve, or should we wait for this PR before merging on master to avoid the accumulation of conflicts? |
As long as you are not doing major refacto it's fine |
m4theushw
approved these changes
Feb 17, 2022
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #3688
Part of #924
Adapt the prop types generation to handle several folders. I unified the TypeScript program / checker creation with
buildApito keep the logic in a single place.Move all the community code from
packages/grid/_modules_/gridtopackages/grid/x-data-grid/src/internalsThis pull request does not remove the
unstable_exports from@mui/x-data-gridbecause we need the new bundling strategy which will come in the next Pull Request.I suggest to do the deep review in #3965 in which you will have a clearer view of the releasable version