Skip to content

[charts] Fix vitest lint error #20550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JCQuintas merged 2 commits into from
Dec 3, 2025
Merged

[charts] Fix vitest lint error #20550

JCQuintas merged 2 commits into from
Dec 3, 2025

Conversation

@bernardobelchior
Copy link
Member

@bernardobelchior bernardobelchior commented Dec 3, 2025 •
edited
Loading

Fix Vitest lint error that happened because #20282 wasn't rebased with master when merged.

@bernardobelchior bernardobelchior added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Dec 3, 2025
@mui-bot
Copy link

mui-bot commented Dec 3, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-20550--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 2b8738d

JCQuintas
JCQuintas requested changes Dec 3, 2025
View reviewed changes
Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it removing the quotes? 🤔

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #20550 will not alter performance

Comparing bernardobelchior:fix-vitest-lint (2b8738d) with master (7a172eb)

Summary

✅ 13 untouched

@bernardobelchior
Copy link
Member Author

bernardobelchior commented Dec 3, 2025

Why is it removing the quotes? 🤔

It's valid in Vitest to pass functions at the first argument of the describe block, but it seems the ESLint plugin doesn't handle it very well, so I've removed that change for now.

It seems like an useful feature so that we don't end up with tests whose describe block names are different from the functions they refer to (which can happen with refactoring).

@bernardobelchior bernardobelchior marked this pull request as ready for review December 3, 2025 13:34
@JCQuintas JCQuintas enabled auto-merge (squash) December 3, 2025 13:41
@JCQuintas JCQuintas merged commit 803fd4d into mui:master Dec 3, 2025
21 checks passed
A-s-h-o-k pushed a commit to A-s-h-o-k/mui-x that referenced this pull request Dec 14, 2025
@bernardobelchior @A-s-h-o-k
[charts] Fix vitest lint error (mui#20550)
fee5235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JCQuintas JCQuintas JCQuintas approved these changes

@alexfauquette alexfauquette Awaiting requested review from alexfauquette

Assignees

No one assigned

Labels

scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bernardobelchior @mui-bot @JCQuintas