[code-infra] Fix missing font loading for local fonts #20480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
added
type: regression
1 task
|
Deploy preview: https://deploy-preview-20480--material-ui-x.netlify.app/ Bundle size report
|
Janpot
commented
Nov 28, 2025
| ); | ||
| } | ||
|
|
||
| if (typeof window !== 'undefined' && process.env.NODE_ENV === 'production') { |
Member
Author
There was a problem hiding this comment.
removing as the import from core _app.js now performs this
Member
|
I'm not able to run this locally. I'm getting this error in the browser: 
Terminal Logs |
Member
|
Not sure what happened. I retried this as suggested by @Janpot and it worked now. Maybe a cache issue? I don't remember if I had purged the |
bernardobelchior
approved these changes
Nov 28, 2025
Member
bernardobelchior
left a comment
bernardobelchior
left a comment
There was a problem hiding this comment.
Seems to be working locally now, and without any warnings 👍
Thanks!
A-s-h-o-k
pushed a commit
to A-s-h-o-k/mui-x
that referenced
this pull request
Dec 14, 2025
mapache-salvaje
pushed a commit
to mapache-salvaje/mui-x
that referenced
this pull request
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #20407 (comment)
The original PR was tested with only google fonts fixed. In the meantime monorepo had also moved to local fonts in
next/font.See https://deploy-preview-20480--material-ui-x.netlify.app/x/react-data-grid/