[charts] Fix tooltip not showing on first render #20115
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20113.
This is the problematic line. We don't add the event listeners if
hasInteractionPlugin, butuseChartInteractionis defined afteruseChartCartesianAxissohasInteractionPluginis false on the first render. The fix is to switch their order, which is doable sinceuseChartInteractiondoesn't depend onuseChartCartesianAxis. I applied this fix to polar charts since they had the same issue.We didn't catch it because there are at least two things causing re-renders on first render:
StrictModeand responsive width, which is why this only manifests whenStrictModeis off and width is pre-defined.Fix confirmation