[charts] Handle undefined id and color in series
#20087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle
undefinedid and color in series.Previously, a pattern like the following would result in an
undefinedfillproperty ifconditionis false:Now, it will use the default color. The same logic applies to the
idproperty.To work around that behavior, a user would need to do this, which is worse DX IMO:
Results
Before:
Screen.Recording.2025-10-24.at.16.16.55.mov
After:
Screen.Recording.2025-10-24.at.16.17.27.mov