[pickers] Keep invalid date state consistent #20040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelengelen
added
type: regression
|
Deploy preview: https://deploy-preview-20040--material-ui-x.netlify.app/ Bundle size report
|
siriwatknp
reviewed
Oct 30, 2025
Member
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
From a rough review, I see:
- some comments are not necessary as the code already explain the logic
- a PR description would be nice to explain how this PR fixes a lot of issues at the same time.
I will do intensive review soon.
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
1 task
packages/x-date-pickers/src/DateField/tests/invalidStateKeyboard.DateField.test.tsx
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Nov 3, 2025
packages/x-date-pickers/src/internals/hooks/useField/useFieldState.ts
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Nov 3, 2025
packages/x-date-pickers/src/internals/hooks/useField/useFieldState.ts
Outdated
Show resolved
Hide resolved
siriwatknp
reviewed
Nov 3, 2025
packages/x-date-pickers/src/internals/hooks/useField/useFieldV6TextField.ts
Show resolved
Hide resolved
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
packages/x-date-pickers/src/internals/hooks/useField/useFieldState.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
siriwatknp
approved these changes
Nov 6, 2025
Member
siriwatknp
left a comment
siriwatknp
left a comment
There was a problem hiding this comment.
👍 Nicely done. Only one comment, better to wait Flavien's response before merging.
siriwatknp
requested changes
Nov 6, 2025
Member
There was a problem hiding this comment.
Oh wait, it breaks this behavior. If it's invalid, I cannot change other section.
I tested the https://deploy-preview-20040--material-ui-x.netlify.app/x/react-date-pickers/date-picker/ (production works fine)
Screen.Recording.2568-11-06.at.10.58.13.mov
flaviendelangle
approved these changes
Nov 6, 2025
Member
flaviendelangle
left a comment
flaviendelangle
left a comment
There was a problem hiding this comment.
Thanks for taking care of it 🙏
packages/x-date-pickers/src/DateField/tests/blurPartialFilling.DateField.test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
Member
|
The latest commit does not fix #17967 Screen.Recording.2568-11-06.at.10.58.13.mov |
Signed-off-by: michel <[email protected]>
Signed-off-by: michel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should keep the invalid state consistent during different phases of the input cycle in the pickers.
This fixes some validation bugs:
Consistent invalid field state
Invalid state "shuffling"
Before:
Screen.Recording.2025-10-30.at.14.52.48.mov
After:
Screen.Recording.2025-10-30.at.14.53.05.mov
Fixes #17967
Fixes #18039
Fixes #18299
Fixes #19777