Skip to content

[code-infra] Remove @mui/monorepo usage for react versioning #19894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 16, 2025
Merged

[code-infra] Remove @mui/monorepo usage for react versioning #19894

merged 13 commits into from
Oct 16, 2025

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Oct 10, 2025 •
edited
Loading

Replace the "npm install" + "set version" with a single step. The goal is:

  • remove usage of @mui/monorepo
  • reduce the amount of actions to get to an installed environment (seems to remove ~20s to ~30s in some cases)
  • correct how we install overrides (must run pnpm dedupe)
  • unify how we do version overrides also for mui v6

Verified in https://app.circleci.com/jobs/github/mui/mui-x/652266

Using overrides: {
  "react": "18.3.1",
  "react-dom": "18.3.1",
  "react-is": "18.3.1",
  "scheduler": "0.23.2"
}

And in https://app.circleci.com/pipelines/github/mui/mui-x/106791/workflows/aa09b947-8b85-4155-a469-be31f19e1867/jobs/652701

Using overrides: {
  "@mui/material": "6.5.0",
  "@mui/system": "6.5.0",
  "@mui/icons-material": "6.5.0",
  "@mui/utils": "6.4.9",
  "@mui/material-nextjs": "6.5.0",
  "@mui/lab": "6.0.1-beta.36"
}

@mui-bot
Copy link

mui-bot commented Oct 10, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19894--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 64a3d71

@Janpot Janpot added scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Oct 10, 2025
@Janpot Janpot marked this pull request as ready for review October 13, 2025 15:06
@Janpot Janpot requested a review from a team October 13, 2025 15:06
Janpot
Janpot commented Oct 15, 2025
View reviewed changes
package.json Outdated
"use-react-version": "node scripts/useReactVersion.mjs",
"use-material-ui-v6": "node scripts/useMaterialUIv6.mjs",
"use-material-ui-next": "node scripts/useMaterialUINext.mjs",
"use-material-ui-v6": "code-infra set-version-overrides --pkg @mui/material@6 @mui/system@6 @mui/icons-material@6 @mui/utils@6 @mui/material-nextjs@6 @mui/lab@latest",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept these for local testing, but happy to remove as well

Janpot
Janpot commented Oct 15, 2025
View reviewed changes
.circleci/config.yml
description: Use material-ui v6 for additional checks and tests
type: boolean
default: false
material-ui-version:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do it the same way as we do react-version

bernardobelchior
bernardobelchior approved these changes Oct 16, 2025
View reviewed changes
.circleci/config.yml Outdated
args="react@$REACT_VERSION"
fi
if [ -n "$MATERIAL_UI_VERSION" ] && [ "$MATERIAL_UI_VERSION" != "stable" ]; then
args="$args @mui/material@$MATERIAL_UI_VERSION @mui/system@$MATERIAL_UI_VERSION @mui/icons-material@$MATERIAL_UI_VERSION @mui/utils@$MATERIAL_UI_VERSION @mui/material-nextjs@$MATERIAL_UI_VERSION @mui/lab@latest"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to always use latest for @mui/lab?

Copy link
Member Author

@Janpot Janpot Oct 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, I just copied what was already there. It was introduced in #15342

edit: I think it's supposed to be latest-v6

@Janpot Janpot mentioned this pull request Oct 16, 2025
Merged
@Janpot
Copy link
Member Author

Janpot commented Oct 16, 2025

I ran the additional workflow with core v6 as a test. The version overrides work correctly, but the workflow is broken, also on master.

@Janpot Janpot merged commit a96fc2c into mui:master Oct 16, 2025
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernardobelchior bernardobelchior bernardobelchior approved these changes

Assignees

No one assigned

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Janpot @mui-bot @bernardobelchior