Skip to content

Conversation

@prakhargupta1
Copy link
Member

@prakhargupta1 prakhargupta1 commented Oct 10, 2025

These demos are from the Overview page. Just reimplemented in the docs folder, it also gives an option for the reader to see the code.

@prakhargupta1 prakhargupta1 added scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. docs Improvements or additions to the documentation. labels Oct 10, 2025
@mui-bot
Copy link

mui-bot commented Oct 10, 2025

Deploy preview: https://deploy-preview-19888--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 3bb4dab

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 10, 2025

CodSpeed Performance Report

Merging #19888 will not alter performance

Comparing prakhargupta1:heatmap-scatter (3bb4dab) with master (7e86b02)

Summary

✅ 12 untouched

@prakhargupta1 prakhargupta1 marked this pull request as ready for review October 10, 2025 09:32
@prakhargupta1
Copy link
Member Author

I need help with the typescript error, no clue how to fix it.

@JCQuintas
Copy link
Member

I need help with the typescript error, no clue how to fix it.

its not a typescript error, you just need to run pnpm docs:typescript:formatted to ensure the js file is the same as the tsx file.

@prakhargupta1
Copy link
Member Author

prakhargupta1 commented Oct 10, 2025

Ran pnpm docs:typescript:formatted but still the error remains. I don't want to add a .preview file still it shows a type error about it. :/

@alexfauquette
Copy link
Member

I don't want to add a .preview file still it shows a type error about it. :/

You don't really have the choice. I think what you're looking for is defaultCodeOpen": false ;)

I've added a commit to fix that, and share dataset accross demo

prakhargupta1 and others added 2 commits October 10, 2025 19:00
Co-authored-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Prakhar Gupta <[email protected]>
Co-authored-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Prakhar Gupta <[email protected]>
@alexfauquette alexfauquette merged commit e91cc56 into mui:master Oct 20, 2025
22 checks passed
@prakhargupta1 prakhargupta1 deleted the heatmap-scatter branch October 21, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants