[DataGridPremium] Get correct active chart id while rebuilding data #19720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminmeh
added
type: bug
|
Deploy preview: https://deploy-preview-19720--material-ui-x.netlify.app/ Bundle size report
|
MBilalShafi
reviewed
Sep 26, 2025
packages/x-data-grid-premium/src/hooks/features/chartsIntegration/useGridChartsIntegration.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
On re-render, active chart id is not in the state in
How come this is not an issue on initial mount?
There was a problem hiding this comment.
Found the answer.
On initial mount, filteredRowsSet and sortedRowsSet events come after the visibleDimensions reference is set, so the calculation runs fine.
On reset (key change), the events come before the visibleDimensions is set, and the chart integration hook falls back to set categories on the top level of the rows.
The changes in this PR make it run correctly regardless of the order of the events.
arminmeh
changed the title
cherniavskii
approved these changes
Sep 26, 2025
arminmeh
force-pushed
the
active-chart-id-ref
branch
from
1eb4c15 to
84290f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction steps
1 .Go to https://mui.com/x/react-data-grid/charts-integration/#row-grouping
2. Click on "Reset demo" button
On re-render, active chart id is not in the state in the cycle where the targeted row depth is being calculated, making the hook skip collecting the data for one level of the rows.
Preview https://deploy-preview-19720--material-ui-x.netlify.app/x/react-data-grid/charts-integration/#row-grouping