Skip to content

[DataGridPremium] Fix stale aggregation state #19690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2025
Merged

[DataGridPremium] Fix stale aggregation state #19690

merged 3 commits into from
Sep 25, 2025

Conversation

@arminmeh
Copy link
Contributor

Fixes #19018

@arminmeh arminmeh requested a review from a team September 24, 2025 14:05
@arminmeh arminmeh added scope: data grid Changes related to the data grid. type: regression A bug, but worse, it used to behave as expected. feature: Aggregation Related to the data grid Aggregation feature labels Sep 24, 2025
@mui-bot
Copy link

mui-bot commented Sep 24, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19690--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 🔺+107B(+0.02%) 🔺+5B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 7960760

@arminmeh arminmeh added the plan: Premium Impact at least one Premium user. label Sep 24, 2025
@arminmeh arminmeh mentioned this pull request Sep 24, 2025
Merged
cherniavskii
cherniavskii approved these changes Sep 24, 2025
View reviewed changes
@arminmeh arminmeh force-pushed the aggregation-lookup-cleanup branch from 68405b7 to 7960760 Compare September 25, 2025 06:58
@arminmeh arminmeh merged commit 8c11f5e into mui:master Sep 25, 2025
21 checks passed
@arminmeh arminmeh deleted the aggregation-lookup-cleanup branch September 29, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees

No one assigned

Labels

feature: Aggregation Related to the data grid Aggregation feature plan: Premium Impact at least one Premium user. scope: data grid Changes related to the data grid. type: regression A bug, but worse, it used to behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[data grid] Activating an aggregate in the first row grouping demo breaks labels

3 participants

@arminmeh @mui-bot @cherniavskii