Skip to content

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Sep 19, 2025

Fixes #19447

  • Link default color is now palette.text.disabled instead of primary for a softer color in both dark and light themes
  • Added source/target keywords to link color
Screen.Recording.2025-09-19.at.17.18.36.mov

@JCQuintas JCQuintas self-assigned this Sep 19, 2025
@JCQuintas JCQuintas added type: new feature Expand the scope of the product to solve a new problem. plan: Pro Impact at least one Pro user. scope: charts Changes related to the charts. labels Sep 19, 2025
Signed-off-by: Jose C Quintas Jr <[email protected]>
@mui-bot
Copy link

mui-bot commented Sep 19, 2025

Deploy preview: https://deploy-preview-19634--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 🔺+53B(+0.01%) 🔺+39B(+0.03%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 544f002

Copy link

codspeed-hq bot commented Sep 19, 2025

CodSpeed Performance Report

Merging #19634 will not alter performance

Comparing JCQuintas:sankey-link-color (544f002) with master (48513a6)1

Summary

✅ 12 untouched

Footnotes

  1. No successful run was found on master (26dbfde) during the generation of this report, so 48513a6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@prakhargupta1
Copy link
Member

prakhargupta1 commented Sep 22, 2025

I think we should keep color: 'source' as the default (it feels more like a default). If someone wants it to be palette.text.disabled they can do it themselves.

@alexfauquette
Copy link
Member

alexfauquette commented Sep 22, 2025

I agree with @prakhargupta1 having looks better to have 'source' as the default value. And introduce a third option like 'neutral' for the gray if we want an easy option that don't requires calling the theme.palette

@JCQuintas
Copy link
Member Author

I agree with @prakhargupta1 having looks better to have 'source' as the default value. And introduce a third option like 'neutral' for the gray if we want an easy option that don't requires calling the theme.palette

neutral they can just select their own imo, so it is easier to just do source/target/color only

@JCQuintas JCQuintas enabled auto-merge (squash) September 22, 2025 12:34
@JCQuintas JCQuintas merged commit ba2428d into mui:master Sep 22, 2025
22 of 23 checks passed
@JCQuintas JCQuintas deleted the sankey-link-color branch September 22, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan: Pro Impact at least one Pro user. scope: charts Changes related to the charts. type: new feature Expand the scope of the product to solve a new problem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts][sankey] Make the default link color a lighter shade of the node color
5 participants