Skip to content

Conversation

bernardobelchior
Copy link
Member

Refactor getAxisExtremum. Applied several small changes:

  • Rename to getAxisExtrema
  • Move the logic for deciding the min/max to getAxisExtrema instead of axisExtremumCallback
  • Change it to a named function so that it shows up in performance traces

@bernardobelchior bernardobelchior added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Sep 19, 2025
@mui-bot
Copy link

mui-bot commented Sep 19, 2025

Deploy preview: https://deploy-preview-19627--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 🔺+22B(+0.01%) 🔺+13B(+0.01%)
@mui/x-charts-pro 🔺+22B(+0.01%) 🔺+12B(+0.01%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against d09f7eb

Copy link

codspeed-hq bot commented Sep 19, 2025

CodSpeed Performance Report

Merging #19627 will not alter performance

Comparing bernardobelchior:refactor-get-axis-extrema (d09f7eb) with master (74f8873)1

Summary

✅ 12 untouched

Footnotes

  1. No successful run was found on master (28566f3) during the generation of this report, so 74f8873 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@bernardobelchior bernardobelchior merged commit 0d10e2c into mui:master Sep 19, 2025
24 of 25 checks passed
@bernardobelchior bernardobelchior deleted the refactor-get-axis-extrema branch September 19, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants