Skip to content

[code-infra] Add copilot instructions specific to x repo #19623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 19, 2025
Merged

[code-infra] Add copilot instructions specific to x repo #19623

merged 7 commits into from
Sep 19, 2025

Conversation

JCQuintas
Copy link
Member

Copilot struggles with tests and formatting, this should help a bit and be a starting point if we need to go further

@JCQuintas JCQuintas requested a review from a team September 18, 2025 16:47
@JCQuintas JCQuintas self-assigned this Sep 18, 2025
@JCQuintas JCQuintas added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). labels Sep 18, 2025
@mui-bot
Copy link

mui-bot commented Sep 18, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19623--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) ▼-9B(-0.01%)
@mui/x-data-grid-premium 0B(0.00%) ▼-5B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) ▼-4B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) ▼-3B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) ▼-2B(-0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against 58ee411

bernardobelchior
bernardobelchior approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@bernardobelchior bernardobelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to mention that we use Vitest and which assertion library to use? Should help clear some confusion

JCQuintas
JCQuintas commented Sep 19, 2025
View reviewed changes
@JCQuintas
Apply suggestion from @JCQuintas
b5f5738 
Signed-off-by: Jose C Quintas Jr <[email protected]>
@JCQuintas JCQuintas enabled auto-merge (squash) September 19, 2025 09:25
@JCQuintas
Document Vitest usage for testing
772bbce 
Signed-off-by: Jose C Quintas Jr <[email protected]>
JCQuintas
JCQuintas commented Sep 19, 2025
View reviewed changes
@JCQuintas JCQuintas merged commit b7b6950 into mui:master Sep 19, 2025
21 checks passed
@JCQuintas JCQuintas deleted the add-initial-copilotinstruction branch September 19, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernardobelchior bernardobelchior bernardobelchior approved these changes

Assignees

@JCQuintas JCQuintas

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JCQuintas @mui-bot @bernardobelchior