Skip to content

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Sep 18, 2025

closes #6036

Preview: https://deploy-preview-19617--material-ui-x.netlify.app/x/react-data-grid/export/

others

This PR add gridDataRowIdsSelector to the selector documentation of rows


@siriwatknp siriwatknp added docs Improvements or additions to the documentation. scope: data grid Changes related to the data grid. recipe labels Sep 18, 2025
@mui-bot
Copy link

mui-bot commented Sep 18, 2025

Deploy preview: https://deploy-preview-19617--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) ▼-1B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) ▼-1B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 🔺+1B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) ▼-2B(-0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against 8443873

@siriwatknp siriwatknp added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label Sep 18, 2025
@siriwatknp siriwatknp requested a review from a team September 22, 2025 08:12
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments ... non-blocking! :shipit:

apiRef.current.updateRows(
idsToDelete.map((id) => ({ id, _action: 'delete' })),
);
} finally {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we have a catch here? Even if it is only throwing we should probably add this. WDYT @MBilalShafi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so because it's not the gist of the demo. Also, handling errors depends on the project, we should not add it.

Co-authored-by: Michel Engelen <[email protected]>
Signed-off-by: Siriwat K <[email protected]>
@siriwatknp siriwatknp merged commit f3305bd into mui:master Sep 23, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. recipe scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[data grid] Extend export for CSV and Excel with server-side data

3 participants