[charts] Fix performance issue with JS animations #19606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-19606--material-ui-x.netlify.app/ Bundle size report
|
bernardobelchior
added
type: bug
CodSpeed Performance ReportMerging #19606 will not alter performanceComparing Summary
|
bernardobelchior
force-pushed
the
fix-animation-perf-issue
branch
from
580b951 to
d32b156
Compare
bernardobelchior
requested review from
JCQuintas and
alexfauquette
as code owners
| import { Transition } from './Transition'; | ||
|
|
||
| // Wait for the next animation frame | ||
| const waitNextFrame = () => |
There was a problem hiding this comment.
Couldn't use vitest fake timers because they were failing on CI when running in browser mode.
There was a problem hiding this comment.
Odd, does the logic required animation frame? It could not work if it just using timers instead.
alexfauquette
approved these changes
Sep 18, 2025
JCQuintas
reviewed
Sep 18, 2025
|
|
||
| await waitNextFrame(); | ||
| expect(callCount()).to.be.equal(reactMajor > 18 ? 3 : 2); | ||
| expect(callCount()).to.be.equal(1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12960 (comment).
Original StackBlitz
StackBlitz pointing to this PR.
Fixes the performance issue with JS animations. In the reproductions above, I'm seeing a reduction for Last Contentful Paint from 8.0s to 0.5s, resulting in a 16x improvement.
The issue was caused by calling
timerFlush()which flushes all timers. This meant that wheneverresume()orfinish()were being called, we were calling all timer callbacks.For 3600 bars, this means that every time a new bar N was added, we were calling N-1 callbacks. That's why if could added a
console.logintimerCallbackyou were seeing more than 200k logs.I removed
timerFlushand had to update the tests but this seems more in line with what would be expected. I've done some manual tests and animations seems to work properly, but I'll do some more extensive testing.Toggling
skipAnimationon and off still seems to be working as well as updating the bar prop while animating:Screen.Recording.2025-09-17.at.14.59.51.mov