[code-infra] Load tsx files in visual regression
#19595
Conversation
JCQuintas
added
type: enhancement
| }); | ||
| }); | ||
|
|
||
| const pickersImports = import.meta.glob<React.ComponentType>('./pickers/**/*.{js,tsx}', { |
There was a problem hiding this comment.
@mui/explore I suppose the files under test/regressions/pickers should be tested, but they weren't before, so I enabled it.
Let me know if you would like to keep this disabled or remove these files instead.
There was a problem hiding this comment.
They were imported as is from the Core 3 years ago, never tested and just migrated when we did BCs
I'll let the @michelengelen and the customer success team decide what to do with them.
The tests are probably very outdated and not representative, but some might be valuable.
There was a problem hiding this comment.
@michelengelen they don't seem to provide much right now as they are being clipped, I could fix them, but do we want to?
There was a problem hiding this comment.
IMHO we can skip them, if they don't provide much value anyways. I haven't touched them ever, so I am mot really sure either. Maybe it's better to start a fresh set of tests? @flaviendelangle definitely has more insights into this than I do.
|
Deploy preview: https://deploy-preview-19595--material-ui-x.netlify.app/ Bundle size report
|
test/regressions/testsBySuite.ts
Outdated
| }); | ||
| Object.keys(chartsImports).forEach((path: string) => { | ||
| const name = path.replace('./charts/', '').replace('.js', ''); | ||
| const name = path.replace('./charts/', '').replace(/\.[A-z]+$/, ''); |
There was a problem hiding this comment.
Suggestion: extract helper to avoid duplicate extension removing logic.
// string based variant is about 2.5x faster as well
const removeExtension = (filePath) => {
const extStart = filePath.lastIndexOf('.');
return extStart >= 0 ? filePath.slice(0, extStart) : filePath;
};
JCQuintas
requested review from
alexfauquette and
bernardobelchior
as code owners
tsxintest/regressionsdocs/data/visual-regression-tests/totest/regressions/charts/pickersfiles intest/regressions/pickers/