Skip to content

Conversation

alexfauquette
Copy link
Member

https://mui-org.slack.com/archives/C02EQ97NV8F/p1757491663178749

This is a hacky solution while waiting to be able to configure the zoom speed.

I use the initialZoom to be as close as possible to the limit between show/hide the last tick.

If you're ok with the hack I can do the same for the two other tests

@alexfauquette alexfauquette added test scope: charts Changes related to the charts. labels Sep 15, 2025
@mui-bot
Copy link

mui-bot commented Sep 15, 2025

Deploy preview: https://deploy-preview-19571--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against d875a0f

Copy link

codspeed-hq bot commented Sep 15, 2025

CodSpeed Performance Report

Merging #19571 will not alter performance

Comparing alexfauquette:fix-test-speed (d875a0f) with master (92e4dc2)1

Summary

✅ 10 untouched

Footnotes

  1. No successful run was found on master (9f1a07f) during the generation of this report, so 92e4dc2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@JCQuintas
Copy link
Member

@alexfauquette logic seems good, I would just re-run it a few times on CI to ensure the test is stable, as this was a pain to setup at the time I did it 😢

@JCQuintas JCQuintas added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label Sep 15, 2025
@alexfauquette alexfauquette marked this pull request as ready for review September 15, 2025 16:10
@alexfauquette
Copy link
Member Author

@JCQuintas I found an even easier workaround: The deltaY does not need to be just 1 or -1 I can be 100 or -100 to increase the wheel amplitude

@JCQuintas
Copy link
Member

@JCQuintas I found an even easier workaround: The deltaY does not need to be just 1 or -1 I can be 100 or -100 to increase the wheel amplitude

🤦 I'm aware of that. I forgot these tests were from before the new gesture manager. I probably fixed the issue that was requiring me to use the for loop... 🤣

@alexfauquette alexfauquette merged commit 58b432e into mui:master Sep 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: charts Changes related to the charts. test type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants