Skip to content

[tree view] Allow to pass null to the icon slots #19569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

[tree view] Allow to pass null to the icon slots #19569

merged 2 commits into from
Sep 23, 2025

Conversation

@flaviendelangle
Copy link
Member

Closes #12548

Not sure if we want the div wrapping the icon to keep its width when it has no icon inside it.
For now I did not change that 👍

@flaviendelangle flaviendelangle self-assigned this Sep 15, 2025
@flaviendelangle flaviendelangle added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: tree view Changes related to the tree view. This includes TreeView, TreeItem. labels Sep 15, 2025
@mui-bot
Copy link

mui-bot commented Sep 15, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19569--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 🔺+61B(+0.10%) 🔺+23B(+0.12%)
@mui/x-tree-view-pro 🔺+61B(+0.07%) 🔺+33B(+0.12%)

Details of bundle changes

Generated by 🚫 dangerJS against 6abb9a7

noraleonte
noraleonte approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@flaviendelangle flaviendelangle merged commit bf71252 into mui:master Sep 23, 2025
21 checks passed
@flaviendelangle flaviendelangle deleted the null-expand-collapse branch September 23, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noraleonte noraleonte noraleonte approved these changes

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees

@flaviendelangle flaviendelangle

Labels

scope: tree view Changes related to the tree view. This includes TreeView, TreeItem. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[tree view] Cannot easily remove the expand and collpase icons

3 participants

@flaviendelangle @mui-bot @noraleonte