[docs] Group demos data into the dataset folder #19549
Conversation
alexfauquette
requested review from
bernardobelchior and
JCQuintas
as code owners
|
Deploy preview: https://deploy-preview-19549--material-ui-x.netlify.app/ Bundle size report
|
| if (context.location === 'tick' && context.defaultTickLabel === '') { | ||
| return ''; | ||
| } | ||
| // valueFormatter: (value: number, context) => { |
There was a problem hiding this comment.
Removing this formats 2 billion as 2G instead of 2B.
There was a problem hiding this comment.
My bad, a mistake from when I was debugging the x-axis hidden labels
| import { ScatterChart } from '@mui/x-charts/ScatterChart'; | ||
| import { PieChart } from '@mui/x-charts/PieChart'; | ||
| import { HighlightScope } from '@mui/x-charts/context'; | ||
| import scatterDataset from '../dataset/random/scatterSimson.json'; |
There was a problem hiding this comment.
What do you mean by "Simson"?
There was a problem hiding this comment.
I missed the "p" of Simpson
| { id: 7, value: 15, label: 'Series H' }, | ||
| ]; | ||
|
|
||
| const itemsNumber = 8; |
There was a problem hiding this comment.
Don't we need to update this? Now there's only 7 items, right?
There was a problem hiding this comment.
This was useless. Probably a legacy piece of code from whene a demo was allowing modifying the number of slices
alexfauquette
added
docs
CodSpeed Performance ReportMerging #19549 will not alter performanceComparing Summary
Footnotes |
alexfauquette
added
the
type: enhancement
moving the scatter random data, and the line chart real world data.
I propos that some data set also export their value formatter, such that for demos that don't focus on the topic we don't need to bather defining again and again how to format dates in the axis/tooltip. We do it once for all nest to the dataset, and so latter refinement will apply to all demos