Skip to content

[tree view] Use Base UI utils whenever possible #19502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2025
Merged

[tree view] Use Base UI utils whenever possible #19502

merged 2 commits into from
Sep 26, 2025

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Sep 9, 2025 •
edited
Loading

I did not migrate the warnOnce from x-internals because Olivier proposed some API changes that would make it closer to our warnOnce and I don't want to migrate one way to then migrate again 😆

@flaviendelangle flaviendelangle self-assigned this Sep 9, 2025
@flaviendelangle flaviendelangle added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: tree view Changes related to the tree view. This includes TreeView, TreeItem. labels Sep 9, 2025
@mui-bot
Copy link

mui-bot commented Sep 9, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19502--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-charts-premium 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 🔺+999B(+1.60%) 🔺+346B(+1.80%)
@mui/x-tree-view-pro 🔺+998B(+1.16%) 🔺+360B(+1.34%)

Details of bundle changes

Generated by 🚫 dangerJS against 658b583

noraleonte
noraleonte approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@noraleonte noraleonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up! 🚀

@flaviendelangle flaviendelangle merged commit 9d7942d into mui:master Sep 26, 2025
21 checks passed
@flaviendelangle flaviendelangle deleted the base-ui-utils-tree-view branch September 26, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noraleonte noraleonte noraleonte approved these changes

@michelengelen michelengelen Awaiting requested review from michelengelen

Assignees

@flaviendelangle flaviendelangle

Labels
scope: tree view Changes related to the tree view. This includes TreeView, TreeItem. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @noraleonte