Skip to content

Conversation

@bernardobelchior
Copy link
Member

This log doesn't seem to be adding much. The default case is considering various locales and we're already logging when we aren't following the default case.

On the other hand, it occupies some space in the terminal for no benefit, so I'd like to know your thoughts on removing it.

image

@bernardobelchior bernardobelchior requested a review from a team September 8, 2025 16:44
@mui-bot
Copy link

mui-bot commented Sep 8, 2025

Deploy preview: https://deploy-preview-19490--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against d3fef77

@bernardobelchior bernardobelchior added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). labels Sep 8, 2025
@bernardobelchior bernardobelchior merged commit a2af7c7 into mui:master Sep 9, 2025
23 of 25 checks passed
@bernardobelchior bernardobelchior deleted the remove-ssr-log branch September 9, 2025 08:24
JCQuintas pushed a commit to JCQuintas/mui-x that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants