[TreeView] Do not mutate props.items in the getItemTree method
#19483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
type: bug
flaviendelangle
changed the title
props.items in the getItemTree method
|
Deploy preview: https://deploy-preview-19483--material-ui-x.netlify.app/ Bundle size report
|
caillou
reviewed
Sep 9, 2025
| const getItemTree = React.useCallback(() => { | ||
| const getItemFromItemId = (itemId: TreeViewItemId): TreeViewBaseItem => { | ||
| const item = itemsSelectors.itemModel(store.state, itemId); | ||
| const itemToMutate = { ...item }; |
There was a problem hiding this comment.
@flaviendelangle This only makes a clone of the outer-most item.
E.g:
const x = {a: {b: []}};
const copy = {...x};
copy.a.b = ['new'];
console.log(x)
// { a: { b: [ 'new' ] } }Don't you need to use structuredClone instead?
const x = {a: {b: []}};
const copy = structuredClone(x);
copy.a.b = ['new'];
console.log(x)
// { a: { b: [ 'new' ] } }Edit: Sorry, my bad. This is a recursive function. Please ignore this comment.
JCQuintas
pushed a commit
to JCQuintas/mui-x
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19482