[DataGrid] perf: fix stringify() for theme objects #19427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
scope: data grid
romgrk
commented
Sep 3, 2025
| import { alpha, darken, lighten, type Theme } from '@mui/material/styles'; | ||
| import { useTheme } from '@mui/material/styles'; | ||
| import { hash, stringify } from '@mui/x-internals/hash'; | ||
| import { hash } from '@mui/x-internals/hash'; |
There was a problem hiding this comment.
The change makes stringify() too specific to theme objects to be alongside hash(), and the function wasn't used anywhere else, so it's been moved here.
|
Deploy preview: https://deploy-preview-19427--material-ui-x.netlify.app/ Bundle size report
|
MBilalShafi
approved these changes
Sep 4, 2025
arminmeh
approved these changes
Sep 4, 2025
JCQuintas
pushed a commit
to JCQuintas/mui-x
that referenced
this pull request
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19414
Make
stringify()more performant.