Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Sep 3, 2025

  • Add disableRowSelectionExcludeModel prop to all DataGrid variants
  • Update row selection logic to respect the new prop
  • Add comprehensive tests for the new functionality
  • Regenerate API documentation
  • Add documentation for disableRowSelectionExcludeModel prop
  • Improve documentation wording for exclude model opt-out
  • Remove redundant test from DataGridPro (already covered in base DataGrid tests)

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copy link
Contributor Author

Copilot AI commented Sep 3, 2025

@MBilalShafi 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

@mui-bot
Copy link

mui-bot commented Sep 3, 2025

Deploy preview: https://deploy-preview-19423--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+144B(+0.04%) 🔺+34B(+0.03%)
@mui/x-data-grid-pro 🔺+144B(+0.03%) 🔺+30B(+0.02%)
@mui/x-data-grid-premium 🔺+105B(+0.02%) 🔺+28B(+0.02%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) ▼-3B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) ▼-2B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) ▼-2B(-0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against 00ac7ac

@MBilalShafi MBilalShafi added scope: data grid Changes related to the data grid. feature: Selection Related to the data grid Selection feature type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Sep 3, 2025
@Copilot Copilot AI changed the title [WIP] [data grid] Allow to opt out of the row selection exclude model [data grid] Add disableRowSelectionExcludeModel prop to opt out of exclude model optimization Sep 3, 2025
@Copilot Copilot AI requested a review from MBilalShafi September 3, 2025 14:19
Copilot finished work on behalf of MBilalShafi September 3, 2025 14:19
@MBilalShafi
Copy link
Member

@copilot Since you added a new prop, you need to regenerate docs by running pnpm docs:api to fix the pipeline.

Copy link
Contributor Author

Copilot AI commented Sep 3, 2025

@copilot Since you added a new prop, you need to regenerate docs by running pnpm docs:api to fix the pipeline.

Done! I've regenerated the API documentation by running pnpm docs:api as requested. The new disableRowSelectionExcludeModel prop is now properly documented in all DataGrid variants (Community, Pro, Premium). The changes have been committed in 869a64f.

Copilot finished work on behalf of MBilalShafi September 3, 2025 14:27
@MBilalShafi
Copy link
Member

@copilot

Can you adjust some documentation related to this addition?

  1. Add a small code snippet about how row selection model looks in the docs section: https://mui.com/x/react-data-grid/row-selection/#controlled-row-selection
  2. In the same section, add a small sub-section on how to opt-out of the type: 'exclude' portraying the newly added prop.
  3. Add the opt-out option to the breaking change related to the exclude model in https://github.com/mui/mui-x/blob/master/docs/data/migration/migration-data-grid-v7/migration-data-grid-v7.md#selection to help the users migrating from previous majors

Copy link
Contributor Author

Copilot AI commented Sep 3, 2025

@copilot

Can you adjust some documentation related to this addition?
...

I've added comprehensive documentation for the disableRowSelectionExcludeModel prop as requested:

  1. Row selection docs: Added code snippet showing the new row selection model structure and a dedicated section explaining how to opt out of exclude model optimization
  2. Migration guide: Added information about the new prop as an opt-out mechanism in the breaking changes section

The documentation now clearly explains:

  • The new row selection model format ({ type: 'include' | 'exclude'; ids: Set<GridRowId> })
  • How to use disableRowSelectionExcludeModel={true} for predictable behavior with explicit row IDs
  • Migration guidance for users upgrading from v7

Changes committed in 72c11f0.

Copilot finished work on behalf of MBilalShafi September 3, 2025 14:47
@MBilalShafi MBilalShafi changed the title [data grid] Add disableRowSelectionExcludeModel prop to opt out of exclude model optimization [DataGrid] Allow to opt out of row selection exclude model Sep 3, 2025
@MBilalShafi MBilalShafi marked this pull request as ready for review September 3, 2025 16:37
@MBilalShafi MBilalShafi requested a review from arminmeh September 3, 2025 16:37
@Copilot Copilot AI requested a review from MBilalShafi September 4, 2025 09:01
Copilot finished work on behalf of MBilalShafi September 4, 2025 09:01
@MBilalShafi MBilalShafi merged commit 9e72e01 into master Sep 4, 2025
27 checks passed
@MBilalShafi MBilalShafi deleted the copilot/fix-19418 branch September 4, 2025 13:02
JCQuintas pushed a commit to JCQuintas/mui-x that referenced this pull request Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: Selection Related to the data grid Selection feature scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants