Skip to content

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Sep 3, 2025

Some improvements can be made by using inline legend, from PR

Screenshot 2025-09-03 at 13 49 16

@JCQuintas JCQuintas self-assigned this Sep 3, 2025
@JCQuintas JCQuintas added docs Improvements or additions to the documentation. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: charts Changes related to the charts. labels Sep 3, 2025
@mui-bot
Copy link

mui-bot commented Sep 3, 2025

Deploy preview: https://deploy-preview-19416--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-pro 0B(0.00%) 0B(0.00%)
@mui/x-data-grid-premium 0B(0.00%) 0B(0.00%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 33b8fee

Copy link

codspeed-hq bot commented Sep 3, 2025

CodSpeed Performance Report

Merging #19416 will not alter performance

Comparing JCQuintas:bar-chart-shiny (33b8fee) with master (3148ff0)1

Summary

✅ 10 untouched

Footnotes

  1. No successful run was found on master (480d03f) during the generation of this report, so 3148ff0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@alexfauquette
Copy link
Member

alexfauquette commented Sep 8, 2025

I've added a commit to extract the data set and removed some sx that apparently do nothing.

The only issue with this demo is the mobile view. We should probably move the legend at the bottom in the case. But it' looks triky. Will be easier with #19382

image

@JCQuintas JCQuintas marked this pull request as ready for review September 15, 2025 09:32
@JCQuintas
Copy link
Member Author

I've added a commit to extract the data set and removed some sx that apparently do nothing.

The only issue with this demo is the mobile view. We should probably move the legend at the bottom in the case. But it' looks triky. Will be easier with #19382

image

fixed now

@prakhargupta1
Copy link
Member

prakhargupta1 commented Sep 15, 2025

The example looks great, we were missing horizontal bar chart demos. About it's placement, is there any reason to put it at the top in the Bars Overview page? I think we should move it to the Demos page.

@JCQuintas JCQuintas merged commit 7f540b1 into mui:master Sep 15, 2025
22 checks passed
@JCQuintas JCQuintas deleted the bar-chart-shiny branch September 15, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation. scope: charts Changes related to the charts. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants