[TreeView] Support flat DOM structure (not publicly exposed) #19350
+74
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
type: new feature
|
Deploy preview: https://deploy-preview-19350--material-ui-x.netlify.app/ Bundle size report
|
flaviendelangle
force-pushed
the
flat-list
branch
from
e30186b to
82fe7d7
Compare
flaviendelangle
commented
Aug 27, 2025
|
|
||
| describe('onClick prop', () => { | ||
| it('should call onClick when clicked, but not when children are clicked for TreeItem', () => { | ||
| it('should call onClick when clicked, and when children are clicked for TreeItem (when using nested DOM structure)', () => { |
There was a problem hiding this comment.
The test was outdated since #12839
It's the only test that is impacted by the new DOM structure.
When the flat DOM structure is enabled automatically by the virtualization, I'll run this test with and without the virtualization and assert the right values 👍
I'm not sure this test testes anything relevant anymore... it jut checks that onClick is forwarded to the DOM element, like any other prop.
flaviendelangle
commented
Aug 27, 2025
| }), | ||
| loading: false, | ||
| error: null, | ||
| domStructure: 'nested', |
There was a problem hiding this comment.
You can try the new DOM structure by setting 'flat' here.
All the tests should pass except one (see the other comment).
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
rita-codes
reviewed
Sep 12, 2025
...ges/x-tree-view/src/internals/plugins/useTreeViewExpansion/useTreeViewExpansion.selectors.ts
Outdated
Show resolved
Hide resolved
…n/useTreeViewExpansion.selectors.ts Co-authored-by: Rita <[email protected]> Signed-off-by: Flavien DELANGLE <[email protected]>
rita-codes
reviewed
Sep 12, 2025
rita-codes
approved these changes
Sep 12, 2025
Signed-off-by: Flavien DELANGLE <[email protected]>
flaviendelangle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9685
The flat DOM structure would be forced when using the virtualization.
Not sure if people should be able to enable it without virtualization, I think we can wait for users feedback before adding this option.