Skip to content

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Aug 27, 2025

@siriwatknp siriwatknp added docs Improvements or additions to the documentation. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: data grid Changes related to the data grid. labels Aug 27, 2025
@mui-bot
Copy link

mui-bot commented Aug 27, 2025

Deploy preview: https://deploy-preview-19349--material-ui-x.netlify.app/

Updated pages:

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+16B(0.00%) 🔺+5B(0.00%)
@mui/x-data-grid-pro 🔺+19B(0.00%) ▼-7B(0.00%)
@mui/x-data-grid-premium 🔺+19B(0.00%) 🔺+14B(+0.01%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 0B(0.00%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 0B(0.00%)

Details of bundle changes

Generated by 🚫 dangerJS against 6b1cbec

Copy link
Member

@MBilalShafi MBilalShafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice looking recipe ❇️

let hasExpectedGross = false;

for (const childId of childIds) {
const childNode = apiRef.current?.getRowNode(childId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, we could make rowNode a part of GridRowClassNameParams, following the same of GridCellParams so that it's already readily available:

/**
* The node of the row that the current cell belongs to.
*/
rowNode: N;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean updating the implementation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should be a minimal and non breaking change.

Copy link
Member

@MBilalShafi MBilalShafi Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't necessarily need to be done in the same PR though. Keeping the scope relevant should also be fine.

@siriwatknp siriwatknp merged commit e0223ef into mui:master Sep 15, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation. recipe scope: data grid Changes related to the data grid. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] How can I add a class in expand panel in row grouping?
5 participants