-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[docs] Add styling row group recipe #19349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview: https://deploy-preview-19349--material-ui-x.netlify.app/ Updated pages:
Bundle size report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice looking recipe ❇️
docs/data/data-grid/recipes-row-grouping/RowGroupingStyling.tsx
Outdated
Show resolved
Hide resolved
docs/data/data-grid/recipes-row-grouping/RowGroupingStyling.tsx
Outdated
Show resolved
Hide resolved
docs/data/data-grid/recipes-row-grouping/RowGroupingStyling.tsx
Outdated
Show resolved
Hide resolved
docs/data/data-grid/recipes-row-grouping/RowGroupingStyling.tsx
Outdated
Show resolved
Hide resolved
let hasExpectedGross = false; | ||
|
||
for (const childId of childIds) { | ||
const childNode = apiRef.current?.getRowNode(childId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better, we could make rowNode
a part of GridRowClassNameParams
, following the same of GridCellParams
so that it's already readily available:
mui-x/packages/x-data-grid/src/models/params/gridCellParams.ts
Lines 44 to 47 in b5026f1
/** | |
* The node of the row that the current cell belongs to. | |
*/ | |
rowNode: N; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean updating the implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it should be a minimal and non breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't necessarily need to be done in the same PR though. Keeping the scope relevant should also be fine.
docs/data/data-grid/recipes-row-grouping/recipes-row-grouping.md
Outdated
Show resolved
Hide resolved
…o docs/row-grouping-styling
…o docs/row-grouping-styling
closes #16172
Preview: https://deploy-preview-19349--material-ui-x.netlify.app/x/react-data-grid/style/#styling-row-groups