Skip to content

[DataGrid] Do not add menu role to the empty actions menu #19338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

[DataGrid] Do not add menu role to the empty actions menu #19338

merged 2 commits into from
Aug 26, 2025

Conversation

arminmeh
Copy link
Contributor

Fixes #19333

@arminmeh arminmeh added type: bug It doesn't behave as expected. accessibility a11y scope: data grid Changes related to the data grid. labels Aug 25, 2025
@mui-bot
Copy link

mui-bot commented Aug 25, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-19338--material-ui-x.netlify.app/

Bundle size report

Bundle Parsed size Gzip size
@mui/x-data-grid 🔺+17B(0.00%) 🔺+11B(+0.01%)
@mui/x-data-grid-pro 🔺+17B(0.00%) 🔺+15B(+0.01%)
@mui/x-data-grid-premium 🔺+17B(0.00%) 🔺+16B(+0.01%)
@mui/x-charts 0B(0.00%) 0B(0.00%)
@mui/x-charts-pro 0B(0.00%) 🔺+3B(0.00%)
@mui/x-date-pickers 0B(0.00%) 0B(0.00%)
@mui/x-date-pickers-pro 0B(0.00%) 🔺+7B(+0.01%)
@mui/x-tree-view 0B(0.00%) 0B(0.00%)
@mui/x-tree-view-pro 0B(0.00%) 🔺+3B(+0.01%)

Details of bundle changes

Generated by 🚫 dangerJS against a7cd0eb

cherniavskii
cherniavskii approved these changes Aug 25, 2025
View reviewed changes
@arminmeh @cherniavskii
do not allocate object
a7cd0eb 
Co-authored-by: Andrew Cherniavskii <[email protected]>
Signed-off-by: Armin Mehinovic <[email protected]>
@arminmeh arminmeh enabled auto-merge (squash) August 26, 2025 05:56
@arminmeh arminmeh added type: bug It doesn't behave as expected. and removed type: bug It doesn't behave as expected. labels Aug 26, 2025
@arminmeh arminmeh merged commit 9c06d42 into mui:master Aug 26, 2025
23 checks passed
@arminmeh arminmeh deleted the fix-actions-cell-a11y branch August 26, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@MBilalShafi MBilalShafi Awaiting requested review from MBilalShafi

Assignees

No one assigned

Labels

accessibility a11y scope: data grid Changes related to the data grid. type: bug It doesn't behave as expected.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[data grid] Grid actions cell renders empty menu div when returning []

3 participants

@arminmeh @mui-bot @cherniavskii